Fix for issue #54 & for registry.instantiate#60
Open
m1nhtu99-hoan9 wants to merge 4 commits intomicrosoft:masterfrom
Open
Fix for issue #54 & for registry.instantiate#60m1nhtu99-hoan9 wants to merge 4 commits intomicrosoft:masterfrom
registry.instantiate#60m1nhtu99-hoan9 wants to merge 4 commits intomicrosoft:masterfrom
Conversation
… instead of the called ctor params
|
|
alexpolozov
suggested changes
Sep 10, 2021
Dockerfile
Outdated
| WORKDIR /app | ||
| RUN pip install --user -r requirements.txt --no-warn-script-location && \ | ||
| pip install --user entmax && \ | ||
| pip install --user entmax stanfordnlp && \ |
Contributor
There was a problem hiding this comment.
Perhaps better moved to setup.py, like other dependencies. IIRC, entmax was special because it hardcoded PyTorch dependency in a weird way, so we had to control the order of its installation.
Author
There was a problem hiding this comment.
I corrected as you commented.
…'stanford-corenlp'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registry.instantiatemethod, in whichinspect.signaturemay call the target's parent class constructor params instead of its constructor params